Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAI] Fix NextObjIndex method to embed objeect type into generated OID #420

Merged
merged 4 commits into from
Aug 8, 2023
Merged

[SAI] Fix NextObjIndex method to embed objeect type into generated OID #420

merged 4 commits into from
Aug 8, 2023

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Aug 7, 2023 •
edited
Loading

Couple changes:

  • fix NextObjIndex and rename to NextObjectId, which embeds correct object type, this will be needed in sai_object_type_query
  • fix dome log messages in get_switch_attribute
  • move GetDeviceId to static, since no longer required to be public
  • fix init_switch.cpp, since previously was using GetDeviceId to init GRPS channel, now this is done inside sai_api_initialize

@kcudnik kcudnik changed the title TEST DO NOT MERGE [SAI] Fix NextObjIndex method to embed objeect id into generated OID Aug 7, 2023
@kcudnik kcudnik changed the title [SAI] Fix NextObjIndex method to embed objeect id into generated OID [SAI] Fix NextObjIndex method to embed objeect type into generated OID Aug 7, 2023
chrispsommers
chrispsommers requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the goal of this PR, but it seems to leave the matter of maintaining nextId-per-object type unfinished. I've no objection to the changes so far though.

@kcudnik
Copy link
Collaborator Author

kcudnik commented Aug 7, 2023

I'm not sure of the goal of this PR, but it seems to leave the matter of maintaining nextId-per-object type unfinished. I've no objection to the changes so far though.

this is next pr in the series of refactoring libsai in dash rep, i don't want to put everything in one big pr, and then face looking for errors if something breaks :D

@kcudnik
Copy link
Collaborator Author

kcudnik commented Aug 8, 2023

can we merge this is all is addressed ?

@chrispsommers chrispsommers merged commit 666da4e into sonic-net:main Aug 8, 2023
3 checks passed
@kcudnik kcudnik deleted the testobj branch August 9, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrispsommers chrispsommers chrispsommers approved these changes

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcudnik @chrispsommers