-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Private Link mapping #327
Conversation
Pending NVGRE from #308 |
dash-pipeline/bmv2/dash_outbound.p4
Outdated
0xffffffffffffffffffffffff); | ||
|
||
set_tunnel_mapping(underlay_dip, | ||
overlay_dmac, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be unchanged
@marian-pritsak , could you please check the build failure? |
Probably the new table attributes for ENI P4 code require them to be set in any test case calling
The c++ libsai test case calls
|
Signed-off-by: Marian Pritsak <[email protected]>
fa7b149
to
e90b0cf
Compare
234fedb
to
9a24a34
Compare
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
@chrispsommers where is this test that's failing? I can't find it in the tests directory.
|
@marian-pritsak I see you found the test case |
Yes, I forgot there are two locations. |
Signed-off-by: Marian Pritsak <[email protected]>
d047a5c
to
53bd552
Compare
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
Signed-off-by: Marian Pritsak <[email protected]>
1609cf6
to
ebfb526
Compare
Signed-off-by: Marian Pritsak <[email protected]>
ebfb526
to
5e191b1
Compare
Signed-off-by: Marian Pritsak <[email protected]>
SAI PR opencomputeproject/SAI#1907 |
@marian-pritsak do you want to request review of this and move forward? |
Notes from 9/27/2023 DASH Community Call. |
Adding Prince & Riff to review |
* main: (75 commits) [dash-SAI] Enable warnings as errors (sonic-net#466) [SAI] wrong code generated in libsai sonic-net#415 (sonic-net#463) Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. (sonic-net#459) DASH pipeline packet flow update proposal. (sonic-net#449) [libsai] Add attr name logging when doing get api (sonic-net#451) Build libsai deb packages in github workflow (sonic-net#450) Add Private Link mapping (sonic-net#327) [SAI] Update SAI submodule to the latest origin/master (sonic-net#446) [dash] Add libsai-debs target to create libsai debian packages (sonic-net#444) update p4 compile dependancy to avoid parallel docker runs (sonic-net#443) [dash] Refactor libsai (sonic-net#438) [dash] Update SAI to latest v1.13 (sonic-net#435) [dash-pipeline] Refactor Makefiles (sonic-net#432) Remove ACL tags from BM (sonic-net#425) [submodule] Update SAI submodule to origin/master (sonic-net#431) [sai-api-gen] Write files only when changes are detected (sonic-net#429) Adds SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION api to dash_underlay_routing (sonic-net#422) [SAI] Add missing check for api initialized [SAI] Print oids in hex form [SAI] Change asserts to return error codes and add missing switch api ...
Signed-off-by: Marian Pritsak [email protected]