Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for the browser platform #176

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added support for the browser platform #176

wants to merge 3 commits into from

Conversation

CallanIwan
Copy link

See #119

Callan Kandasamy and others added 2 commits May 26, 2015 14:18
@aoberoi
Copy link
Collaborator

aoberoi commented May 26, 2015

thanks @CallanIwan, it seems like a better option would be to have a file which loads and evals the latest opentok.min.js from the server, rather than checking in one snapshot that will soon be out of date and need to be maintained. what do you think?

@CallanIwan
Copy link
Author

Yeah that sounds like the better option. The export (module.exports =
window.OT;) line has to be added to the opentok js library for the browser
to work.

2015-05-26 20:33 GMT+02:00 Ankur Oberoi [email protected]:

thanks @CallanIwan https://github.com/CallanIwan, it seems like a
better option would be to have a file which loads and evals the latest
opentok.min.js from the server, rather than checking in one snapshot that
will soon be out of date and need to be maintained. what do you think?

—
Reply to this email directly or view it on GitHub
#176 (comment)
.

Moved the www/browser folder to src/browser.
8ed5c4a 
Added downloadOpenTokJS to download the latest version and replace the snapshot in src/browser, it also appends the module export to the opentok.js.
Also made the following changes to the iOS SDK download script:
	- Added a version variable.
	- added code to remove the downloaded SDK.tar.bz2 after extraction and moving.
	- added code to remove the empty SDK folder in root after moving.
@CallanIwan
Copy link
Author

@aoberoi As you can see in the commit comments I added the requested changes and also made some minor changes to the download of IOS SDK.
Unfortunately I could not use the minified version of the OpenTokJS Client. This minified version has also uglified functions and variables. I needed to add module.exports = window.OT; to the file in order to work within Cordova.
If you know how to add this in the minified version I could download the minified, but from this point I don't see how.

@aoberoi
Copy link
Collaborator

aoberoi commented May 29, 2015

excellent work @CallanIwan, i'm going to review it tomorrow, but I just wanted to say thanks so much.

@derwaldgeist
Copy link

When is tomorrow? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CallanIwan @aoberoi @derwaldgeist