fix: support --set boolean and numberic params #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are there any numeric options available currently? Can we implement the logic as a precautionary measure? |
|
Yeah, I could do that if you'd like? Note that just like boolean it will be an assumption that anything that "looks like" a number will be parsed as a number, just like "true" and "false" strings "look like" booleans are parsed as booleans. I think it's a safe assumption for now, especially since I don't think there are any variable string options? |
|
Yes, I agree. Please do it. Also, I noticed that this parameter is missing in the readme document. Could you also include it there? |
jbedard
force-pushed
the
extends-options-bool
branch
from
64ecf13
to
babdfce
Compare
jbedard
force-pushed
the
extends-options-bool
branch
from
babdfce
to
8c14194
Compare
|
Updated 👍 |
songkeys
changed the title
|
Thank you for the effort! |
|
Thanks for the quick review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't think of this one at first. Note that we'll have the same issue with numbers if there are any numeric options.