Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cli overrides param #19

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Sep 21, 2023

What is the best name for the param? I would have used --override if -o wasn't already used for the output 🤷

@songkeys
Copy link
Owner

songkeys commented Sep 21, 2023

Thank you for this PR.

GPT says: You can use --force or --replace as a suitable replacement. These names convey the idea that the parameter allows you to forcefully override or replace certain settings or values.

What do you think?

Edit: Actaully, -s, --set <name>=<value> looks good to me. I also think -v, --value <name>=<value> could be a good name given that the value set might not exist yet and thus it's not "overrides" but just "sets".

@jbedard
Copy link
Contributor Author

jbedard commented Sep 21, 2023

Note that this is essentially https://swc.rs/docs/usage/cli#--config--c, using --config to "override" a value. I'd still vote for --set out of all these options but the choice is yours...

@songkeys
Copy link
Owner

It looks good to me.

@songkeys songkeys merged commit e15ab53 into songkeys:main Sep 21, 2023
2 of 3 checks passed
@jbedard jbedard deleted the extends-options branch September 23, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants