Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor NFC #26

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

WIP: Refactor NFC #26

wants to merge 4 commits into from

Conversation

nickray
Copy link
Member

@nickray nickray commented Oct 9, 2020

WIP / do not merge, however feedback is welcome!

Several goals:

  • rename the iso14443 library to nfc-device, bringing it in closer analogy with usb-device.
  • this then turns fm11nc08 into something analogous to a UsbBus implementation
  • remove dependency of fm11nc08 on lpc55-hal
  • de-C the FM11NC08 driver, adding more types (using bitflags library as elsewhere), using more Rust combinators, using closures to DRY up, etc.
  • define the contact/contactless interchanges in iso7816 itself (not optimal, but better than in apdu-dispatch, IMO) to avoid a dependency of usbd-ccid and nfc-device on apdu-dispatch, which is more opinionated and particular to us
  • fix minor regressions

Out of scope is a closer re-union of apdu-dispatch and [ctap]hid-dispatch.

@nickray
Copy link
Member Author

nickray commented Jan 6, 2021

stale, will redo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickray