Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istio bug report on failure #9458

Merged
merged 21 commits into from
May 9, 2024

Conversation

npolshakova
Copy link
Contributor

@npolshakova npolshakova commented May 7, 2024

Description

  • Checks httpbin is in a healthy state after applying the setup manifest. This ensures the Istio sidecar has been successfully injected
  • Bumps the timeout for curl requests as part of the Istio strict/permissive peer auth tests
  • The Istio e2e tests will upload the bug report on failure as an artifact.

Context

This will help debug why the we needed to switch from the ubuntu-22.04 runner to the gme-runner in solo-projects:
https://solo-io-corp.slack.com/archives/C06C8RA01NF/p1714752477497519

Solo-projects PR: https://github.com/solo-io/solo-projects/pull/6154/files

Example upload: https://github.com/solo-io/gloo/actions/runs/9022110605/job/24790897959?pr=9458

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6048

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Visit the preview URL for this PR (updated for commit aa99cc4):

https://gloo-edge--pr9458-npolshak-add-istio-d-kzrqshh2.web.app

(expires Thu, 16 May 2024 20:41:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

test/kubernetes/testutils/cluster/istio.go Outdated Show resolved Hide resolved
.github/workflows/pr-kubernetes-tests.yaml Outdated Show resolved Hide resolved
test/kubernetes/e2e/features/istio/no_mtls_suite.go Outdated Show resolved Hide resolved
test/kubernetes/testutils/cluster/istio.go Outdated Show resolved Hide resolved
test/kubernetes/testutils/cluster/istio.go Show resolved Hide resolved
test/kubernetes/testutils/cluster/istio.go Outdated Show resolved Hide resolved
test/kubernetes/testutils/runtime/repo.go Outdated Show resolved Hide resolved
sam-heilbron
sam-heilbron previously approved these changes May 9, 2024
.github/workflows/pr-kubernetes-tests.yaml Show resolved Hide resolved
.github/workflows/pr-kubernetes-tests.yaml Show resolved Hide resolved
test/kubernetes/testutils/runtime/repo.go Outdated Show resolved Hide resolved
test/kubernetes/e2e/test.go Outdated Show resolved Hide resolved
sam-heilbron
sam-heilbron previously approved these changes May 9, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit f55d646 into main May 9, 2024
23 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the npolshak/add-istio-debug-report-on-failure branch May 9, 2024 20:53
@npolshakova npolshakova mentioned this pull request May 13, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants