-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gateway2] Updates Gateway Controller Watch Predicate #10107
base: main
Are you sure you want to change the base?
Conversation
e362896
to
a16fce8
Compare
Issues linked to changelog: |
a16fce8
to
81a0892
Compare
2f27f38
to
2996810
Compare
/kick |
82142c3
to
f3d37ef
Compare
Previously, the controller would only watch Gateway objects for `generation` field changes which is not updated when annotations change. Since Gateway reconciliation should be triggered when the `gateway.gloo.solo.io/gateway-parameters-name` annotation is added, removed, or modified, the predicate was updated to check for changes in either the generation field or the annotations. Fixes solo-io#10099 Signed-off-by: Daneyon Hansen <[email protected]>
f3d37ef
to
73aa22f
Compare
s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams, proxyService, proxyDeployment) | ||
err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsManifestFile) | ||
s.NoError(err, "can delete manifest") | ||
s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a merge issue but can this line be deleted since we also check gwParams below?
s.NoError(err, "can delete manifest") | ||
s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gtw) | ||
|
||
err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsManifestFile) | ||
s.NoError(err, "can delete manifest") | ||
s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams) | ||
|
||
err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsCustomManifestFile) | ||
s.NoError(err, "can delete manifest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can all the NoError
have different error messages (e.g. append the manifest filename)?
@@ -0,0 +1,10 @@ | |||
changelog: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to move changelog to beta24
Previously, the controller would only watch Gateway objects for
generation
field changes which is not updated when annotations change. Since Gateway reconciliation should be triggered when thegateway.gloo.solo.io/gateway-parameters-name
annotation is added, removed, or modified, the predicate was updated to check for changes in either the generation field or the annotations.Fixes #10099