regen manifest during release step (#1244)

* regen manifest during release step

cloudbuild.yaml

@@ -191,10 +191,9 @@ steps:
   waitFor: ['build-test-assets', 'get-credentials']
   id: 'regression-tests-cluster-lock'
 
-# 1) Run make targets to push docker images, compile manifests, produce release artifacts, deploy docs
-# 2) Publish helm chart
+# 1) Run make targets to push docker images
 - name: 'gcr.io/$PROJECT_ID/go-make:0.1.12'
-  args: ['docker-push', 'manifest', 'upload-github-release-assets', 'push-docs']
+  args: ['docker-push']
   env:
   - 'DOCKER_CONFIG=/workspace/docker-config'
   - 'TAGGED_VERSION=$TAG_NAME'
@@ -203,10 +202,21 @@ steps:
   - 'HELM_HOME=/root/.helm' # tell helm where to find data
   dir: './gopath/src/github.com/solo-io/gloo'
   secretEnv: ['GITHUB_TOKEN']
-  id: 'release'
-  # wait for everything else to compelete.
-
-# Sync helm chart data back to google storage bucket
+  id: 'release-images'
+# 2) Publish helm chart, compile manifests, produce release artifacts, deploy docs
+# isolating this portion of the release in order to force the manifest to be regenerated with the tagged version
+- name: 'gcr.io/$PROJECT_ID/go-make:0.1.12'
+  args: ['manifest', 'upload-github-release-assets', 'push-docs', '-B']
+  env:
+  - 'DOCKER_CONFIG=/workspace/docker-config'
+  - 'TAGGED_VERSION=$TAG_NAME'
+  - 'PROJECT_ROOT=github.com/solo-io/gloo'
+  - 'GOPATH=/workspace/gopath'
+  - 'HELM_HOME=/root/.helm' # tell helm where to find data
+  dir: './gopath/src/github.com/solo-io/gloo'
+  secretEnv: ['GITHUB_TOKEN']
+  id: 'release-chart'
+# 3) Sync helm chart data back to google storage bucket
 - name: 'gcr.io/$PROJECT_ID/go-make:0.1.12'
   args: ['save-helm']
   env: