Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish #72

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+29 −5
Open

Spanish #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ef3c3a
Adds missing this_file_language values for the this_file_language keys.
mutalis Sep 5, 2016
b58c1b0
Removes generic locale for spanish in favor of a country-region local…
mutalis Sep 5, 2016
eb9863d
Fixes obsolete Rubocop style rule. It has been renamed to SpaceBefore…
mutalis Sep 5, 2016
31b0d5e
Uses the es.yml file for the es-ES spain region.
mutalis Sep 5, 2016
39e2584
Add tests for the Spanish locale.
mutalis Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .hound.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Style/Documentation:
Enabled: false

# Neatly aligned code is too swell.
Style/SingleSpaceBeforeFirstArg:
Style/SpaceBeforeFirstArg:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not belong into this PR. Could you please open a separate one?

Enabled: false

# Don't mess with RSpec DSL.
Expand Down
2 changes: 1 addition & 1 deletion config/locales/es-EC.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ es-EC:
available_locales: Locales Disponibles
language: Idioma
localization_settings: Ajustes Localización
this_file_language: Español
this_file_language: Español (Ecuador)
icon: Icono
identifier:
image: Imagen
Expand Down
2 changes: 1 addition & 1 deletion config/locales/es-MX.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ es-MX:
available_locales: Traduciones Disponibles
language: Idioma
localization_settings: Ajustes de traducciones
this_file_language:
this_file_language: Español (Mexico)
icon: Icono
identifier:
image: Imagen
Expand Down
2 changes: 1 addition & 1 deletion config/locales/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ es:
available_locales: Locales Disponibles
language: Idioma
localization_settings: Ajustes Localización
this_file_language: Español
this_file_language: Español (España)
icon: Icono
identifier:
image: Imagen
Expand Down
26 changes: 25 additions & 1 deletion spec/features/translation_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,35 @@ def translation
end
end

# Chilean spanish is chosen
# Spanish of Chile is chosen.
context 'when current locale is Chilean Spanish' do
it 'translation is available' do
I18n.locale = :'es-CL'
expect(translation).to eq 'Código Postal'
end
end

# Spanish of Mexico is chosen.
context 'when current locale is Chilean Spanish' do
it 'translation is available' do
I18n.locale = :'es-MX'
expect(translation).to eq 'Código Postal'
end
end

# Spanish of Ecuador is chosen.
context 'when current locale is Chilean Spanish' do
it 'translation is available' do
I18n.locale = :'es-EC'
expect(translation).to eq 'Código Postal'
end
end

# Spanish of Spain is chosen.
context 'when current locale is Chilean Spanish' do
it 'translation is available' do
I18n.locale = :es
expect(translation).to eq 'Código Postal'
end
end
end