Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing one <title> renders all previous <title>s #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yume-chan
Copy link

@yume-chan yume-chan commented Oct 23, 2024

removeTag missing a break causing all previous <title> tags to be rendered.

Repro playground: https://playground.solidjs.com/anonymous/4fa1f8e7-fcb6-4f6c-a521-daf6207fc779 (looks like @solidjs/meta doesn't work well with HMR, so I need to refresh the preview every time I edited the source code)

For whatever reason, I need to add babel-jest package to root package.json for tests to run. I installed with [email protected] but it still dramatically changed the lockfile, however, it didn't add any new packages.

Output from pnpm test after cloning and pnpm i:

~/solidjs/solid-meta main 3s
❯ pnpm test

> @solidjs/[email protected] test /home/solidjs/solid-meta
> jest && npm run test:types

: ● Validation Error:

  Module babel-jest in the transform option was not found.
         <rootDir> is: /home/solidjs/solid-meta

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

 ELIFECYCLE  Test failed. See above for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant