Refactor and add tests #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
86bd99a
to
4773f04
Compare
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
4773f04
to
8e387ee
Compare
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
8e387ee
to
d155ad9
Compare
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
d155ad9
to
49f7aee
Compare
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
49f7aee
to
65e9aac
Compare
mikemaccana
commented
Jan 2, 2024
| @@ -45,7 +45,7 @@ export default function Home() { | |||
| }); | |||
| const [showVerifyDialog, setShowVerifyDialog] = useState<boolean>(false); | |||
| const toaster = useToast(); | |||
| const [network, setSelectedNetwork] = useState('devnet'); | |||
| const [network, setSelectedNetwork] = useState("devnet"); | |||
There was a problem hiding this comment.
This is just linting, run automatically on save.
Woody4618
approved these changes
Jan 3, 2024
This PR moves logic out of the request handler into their own testable functions, adds a bunch of tests, and uses GitHub Actions to run the tests. add: tests using jest refactor: move checks out of request handler into own files add: CI using github actions add: some console.debug() with reason for each rejection refactor: use getKeypairFromEnvironment() refactor: use a character range to clean out IP address separators in a single step add: README updates chore: formatting only fix: ignore .env files add: more README bits refactor: revert to getting FAUCET_KEYPAIR on every request (it gives better error messages and allows up to fix environment live) add: minor docs and .gitignore tweaks. add: more README bits
mikemaccana
force-pushed
the
refactor-and-add-tests
branch
from
65e9aac
to
ca4c82c
Compare
… debug in it's UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves logic out of the request handler into their own testable functions, adds a bunch of tests, and uses GitHub Actions to run the tests.
add: tests using jest
refactor: move checks out of request handler into own files
add: CI using github actions
add: some console.debug() with reason for each rejection
refactor: use getKeypairFromEnvironment()
refactor: use a character range to clean out IP address separators in a single step
add: README updates