Revert XxxRef from Extension Function to Interface Function
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted the `XxxRef` implementation from an extension function back to an interface-based function due to unexpected behavior when combining `PreviewClient` for Compose with `QueryCachingStrategy.NetworkFirst`. By reverting to an interface-based function, PreviewClient can handle the `resume` function properly, ensuring expected behavior across all combinations. refs: #70
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reverted the
XxxRefimplementation from an extension function back to an interface-based function due to unexpected behavior when combiningPreviewClientfor Compose withQueryCachingStrategy.NetworkFirst. By reverting to an interface-based function, PreviewClient can handle theresumefunction properly, ensuring expected behavior across all combinations.soil/soil-query-compose/src/commonMain/kotlin/soil/query/compose/QueryCachingStrategy.kt
Line 148 in 14f9c21
refs: #70