Support custom chain IDs #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34c7260.
- Add predefined networks as static values - Support custom chain ids - Add helper initializers and methods
DelevoXDG
changed the base branch from
main
to
revert-142-feat/138-remove-starknet-chain-id
THenry14
approved these changes
Feb 19, 2024
Base automatically changed from
revert-142-feat/138-remove-starknet-chain-id
to
main
February 19, 2024 10:24
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
StarknetChainIda structLinked issues
Closes #152
Breaking changes
StarknetChainIdis no longer an enumStarknetChainId.mainnet->StarknetChainId.main