Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sequencer transaction in favor of Transaction with an optional hash #127

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Remove Sequencer transaction in favor of Transaction with an optional hash #127

merged 6 commits into from
Jan 10, 2024

Conversation

DelevoXDG
Copy link
Collaborator

@DelevoXDG DelevoXDG commented Jan 9, 2024 •
edited
Loading

Describe your changes

Helper PR to simplify the process of adding v3 transactions in #124

  • Removed StarknetSequencerTransaction; Move its optional hash field to StarknetTransaction
  • Update StarknetInvokeTransactionV1 and StarknetDeployAccountTransactionV1 constructors to estimate version based on whether they're intended for fee estimation
  • Removed constructor w/ sequencer tx as a parameter in StarknetInvokeTransactionV1 and StarknetDeployAccountTransactionV1
  • Removed StarknetSequencerInvokeTransaction, StarknetSequencerDeployAccountTransaction
  • Removed testSequencerInvokeTransactionDecoding

Linked issues

Closes #41

Breaking changes

  • This issue contains breaking changes
  • Removed StarknetSequencerTransaction
  • Removed StarknetSequencerInvokeTransaction; Uses of StarknetSequencerInvokeTransaction are now of type StarknetInvokeTransactionV1
  • Removed StarknetSequencerDeployAccountTransaction; Uses of StarknetSequencerDeployAccountTransaction are now of type StarknetDeployAccountTransactionV1
  • Removed constructor w/ sequencer tx as a parameter in StarknetInvokeTransactionV1; Updated default one
  • Removed constructor w/ sequencer tx as a parameter in StarknetDeployAccountTransactionV1; Updated default one

@DelevoXDG DelevoXDG merged commit d7c0aff into main Jan 10, 2024
1 check passed
@DelevoXDG DelevoXDG deleted the chore/41-remove-sequencer-tx branch January 10, 2024 09:51
@DelevoXDG DelevoXDG mentioned this pull request Jan 17, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Sequencer transaction in favour of Transaction with optional hash field
2 participants
@DelevoXDG @THenry14