Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static fields with single constants field in DevnetClient #109

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

DelevoXDG
Copy link
Collaborator

@DelevoXDG DelevoXDG commented Oct 11, 2023

Describe your changes

The xcodebuild docbuild command is the part of release CI workflow, which currently fails because of this command.
Apparently, the reason is using static values from DevnetClient, which fails because DevnetClient is internal, even though building and testing using XCode istelf works without issue despite that.

Since we probably want to keep DevnetClient and classes it uses internal, we could instead use enum DevnetClientConstants to hold the constants. We could then:

  • Access DevnetClientConstants in methods inside DevnetClient methods when we need default values for arguments.
  • Add constants field to easily access constants from DevnetClientProtocol from outside without needing to be aware of DevnetClientConstants.

Linked issues

Closes #108

Breaking changes

  • This issue contains breaking changes

Copy link

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DelevoXDG DelevoXDG merged commit 06e04fb into main Oct 11, 2023
1 check passed
@DelevoXDG DelevoXDG deleted the fix/108-devnet-static-fields branch October 11, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xcodebuild docbuild fails
2 participants