Replace static fields with single constants field in DevnetClient #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
xcodebuild docbuild
command is the part of release CI workflow, which currently fails because of this command.Apparently, the reason is using static values from
DevnetClient
, which fails becauseDevnetClient
is internal, even though building and testing using XCode istelf works without issue despite that.Since we probably want to keep
DevnetClient
and classes it uses internal, we could instead use enumDevnetClientConstants
to hold the constants. We could then:DevnetClientConstants
in methods insideDevnetClient
methods when we need default values for arguments.constants
field to easily access constants fromDevnetClientProtocol
from outside without needing to be aware ofDevnetClientConstants
.Linked issues
Closes #108
Breaking changes