Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error in scarb package with non-[lib] packages #856

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Throw an error in scarb package with non-[lib] packages #856

merged 1 commit into from
Nov 9, 2023

Conversation

tomek0123456789
Copy link
Contributor

Closes #735

@tomek0123456789 tomek0123456789 self-assigned this Nov 3, 2023
maciektr
maciektr reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!! 🔥

scarb/src/ops/package.rs Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Nov 6, 2023
View reviewed changes
scarb/src/ops/package.rs Outdated Show resolved Hide resolved
scarb/src/ops/package.rs Outdated Show resolved Hide resolved
mkaput
mkaput approved these changes Nov 6, 2023
View reviewed changes
scarb/tests/package.rs Outdated Show resolved Hide resolved
mkaput
mkaput approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maciektr
maciektr approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tomek0123456789 tomek0123456789 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 6929619 Nov 9, 2023
11 checks passed
@tomek0123456789 tomek0123456789 deleted the tomek/735-fix-non-lib-packages branch November 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@mkaput mkaput mkaput approved these changes

Assignees

@tomek0123456789 tomek0123456789

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-[lib] packages should not be possible to package
3 participants
@tomek0123456789 @mkaput @maciektr