Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Procedural macro compilation #1110

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Procedural macro compilation #1110

merged 1 commit into from
Feb 22, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Feb 1, 2024 •
edited
Loading

This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Closed
Merged
@maciektr maciektr changed the base branch from spr/main/a3155bbf to main February 2, 2024 14:29
@maciektr maciektr mentioned this pull request Feb 2, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/a3155bbf February 2, 2024 14:29
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2024
@maciektr
Allow compilation of packages with no-core flag enabled. (#1112)
8f7c40f 
commit-id:5a5989db

---

**Stack**:
- #1100
- #1110
- #1093
- #1092
- #1091
- #1060
- #1059
- #1112 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2024
@maciektr
Add builtin prop on cairo plugin target definition (#1059)
43da779 
commit-id:350fe920

---

**Stack**:
- #1100
- #1110
- #1093
- #1092
- #1091
- #1060
- #1059 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr changed the base branch from spr/main/a3155bbf to main February 6, 2024 15:29
@maciektr maciektr changed the base branch from main to spr/main/a3155bbf February 6, 2024 15:29
@maciektr maciektr requested a review from mkaput February 19, 2024 14:36
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
mkaput
mkaput requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my answers

github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement procedural macro host generate_code for attribute macro (#…
336751b 
…1091)

Resolves #1127

commit-id:e59370d2

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093
- #1091 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr force-pushed the spr/main/aebc6424 branch 2 times, most recently from 0244f29 to 7494afe Compare February 21, 2024 15:29
@maciektr maciektr requested a review from mkaput February 21, 2024 15:29
mkaput
mkaput requested changes Feb 21, 2024
View reviewed changes
scarb/src/process.rs Outdated Show resolved Hide resolved
Base automatically changed from spr/main/a3155bbf to main February 21, 2024 17:11
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement loading shared libraries for proc macro plugins (#1093)
21e6d18 
Resolves #1128

commit-id:a3155bbf

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Procedural macro compilation
252efc6 
Resolves #1129

commit-id:aebc6424
@maciektr maciektr requested a review from mkaput February 21, 2024 17:30
@maciektr maciektr mentioned this pull request Feb 22, 2024
Merged
@maciektr maciektr added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit bffd585 Feb 22, 2024
42 checks passed
@maciektr maciektr deleted the spr/main/aebc6424 branch February 22, 2024 14:31
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement procedural macro package compilation mechanism
2 participants
@maciektr @mkaput