Change default value from u32::max to none in order to support older …

…versions of snforge
software-mansion · Jan 17, 2024 · b5133cd · b5133cd
1 parent f44a480
commit b5133cd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs b/extensions/scarb-snforge-test-collector/src/compilation/test_collector/config.rs
@@ -147,15 +147,22 @@ pub fn forge_try_extract_test_config(
 
     let result = maybe_test_config.map(
         |TestConfig {
-             available_gas,
+             mut available_gas,
              expectation,
              ignored,
-         }| SingleTestConfig {
-            available_gas,
-            expected_result: expectation.into(),
-            ignored,
-            fork_config,
-            fuzzer_config,
+         }| {
+            // Older versions will crash if the default is passed through
+            if available_gas.is_some_and(|gas_amt| gas_amt == u32::MAX as usize){
+                available_gas = None
+            }
+
+            SingleTestConfig {
+                available_gas,
+                expected_result: expectation.into(),
+                ignored,
+                fork_config,
+                fuzzer_config,
+            }
         },
     );
     Ok(result)

diff --git a/extensions/scarb-snforge-test-collector/tests/test.rs b/extensions/scarb-snforge-test-collector/tests/test.rs
@@ -50,7 +50,7 @@ fn forge_test_locations() {
 
     assert_eq!(
         &json[0]["test_cases"][0]["available_gas"],
-        &Value::Number(Number::from(u32::MAX))
+        &Value::Null
     );
     assert_eq!(&json[0]["test_cases"][0]["expected_result"], "Success");
     assert_eq!(&json[0]["test_cases"][0]["fork_config"], &Value::Null);