Merge pull request #2047 from ramkishor-ch/issue_2014

Fixed Description and some features are missing in slcli block snapshot-set-notification, slcli block subnets-assign, slcli block subnets-list, slcli block subnets-remove
softlayer · Jul 24, 2023 · 029e87d · 029e87d
2 parents b6e6f2d + f1e1839
commit 029e87d
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/SoftLayer/CLI/block/snapshot/set_notify_status.py b/SoftLayer/CLI/block/snapshot/set_notify_status.py
@@ -20,9 +20,8 @@ def cli(env, volume_id, enable):
     """Enables/Disables snapshot space usage threshold warning for a given volume."""
     block_manager = SoftLayer.BlockStorageManager(env.client)
 
-    status = block_manager.set_volume_snapshot_notification(volume_id, enable)
+    block_manager.set_volume_snapshot_notification(volume_id, enable)
 
-    if status:
-        click.echo(
+    click.echo(
             'Snapshots space usage threshold warning notification has bee set to %s for volume %s'
             % (enable, volume_id))
diff --git a/SoftLayer/CLI/block/subnets/assign.py b/SoftLayer/CLI/block/subnets/assign.py
@@ -14,6 +14,12 @@
 def cli(env, access_id, subnet_id):
     """Assign block storage subnets to the given host id.
 
+    EXAMPLE::
+
+                slcli block subnets-assign 111111 --subnet-id 222222
+                slcli block subnets-assign 111111 --subnet-id 222222 --subnet-id 333333
+                ACCESS_ID is the host_id obtained by: softlayer slcli block access-list <volume_id>
+
     access_id is the host_id obtained by: slcli block access-list <volume_id>
 
     SoftLayer_Account::iscsiisolationdisabled must be False to use this command

diff --git a/SoftLayer/CLI/block/subnets/list.py b/SoftLayer/CLI/block/subnets/list.py
@@ -21,6 +21,11 @@
 def cli(env, access_id):
     """List block storage assigned subnets for the given host id.
 
+    Example::
+
+                slcli block subnets-list 12345678
+                ACCESS_ID is the host_id obtained by: softlayer slcli block access-list <volume_id>
+
     access_id is the host_id obtained by: slcli block access-list <volume_id>
     """
 

diff --git a/SoftLayer/CLI/block/subnets/remove.py b/SoftLayer/CLI/block/subnets/remove.py
@@ -14,6 +14,12 @@
 def cli(env, access_id, subnet_id):
     """Remove block storage subnets for the given host id.
 
+    Example::
+
+                slcli block subnets-remove 111111 --subnet-id 222222
+                slcli block subnets-remove 111111 --subnet-id 222222 --subnet-id 333333
+                ACCESS_ID is the host_id obtained by: slcli block access-list <volume_id>
+
     access_id is the host_id obtained by: slcli block access-list <volume_id>
 
     SoftLayer_Account::iscsiisolationdisabled must be False to use this command