support sofa registry kubernetes

sofastack · Jan 26, 2024 · 2246b66 · 2246b66
1 parent 50d15d2
commit 2246b66
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/...-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java b/...-kubernetes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/KubernetesRegistry.java
@@ -230,11 +230,9 @@ public void batchUnSubscribe(List<ConsumerConfig> configs) {
     public void destroy() {
         // unRegister provider
         providerInstances.forEach((k, v) -> unRegister(k));
-        providerInstances.clear();
 
         // unRegister consumer
         consumerListeners.forEach((k, v) -> unSubscribe(k));
-        consumerListeners.clear();
 
         // close kubernetes client
         kubernetesClient.close();

diff --git a/...tes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java b/...tes/src/main/java/com/alipay/sofa/rpc/registry/kubernetes/util/KubernetesConfigUtils.java
@@ -65,6 +65,7 @@ public static Config buildKubernetesConfig(RegistryConfig registryConfig) {
 
     private static String buildMasterUrl(RegistryConfig registryConfig) {
         String address = registryConfig.getAddress();
+        // TODO maybe use Config property
         if (StringUtils.isNotBlank(address)) {
             return "http://" + address;
         }