Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve assign ops/s by 2x #395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Kinbaum
Copy link

@Kinbaum Kinbaum commented Apr 5, 2024

Description

Enhanced the assign function for better performance by replacing Object.entries/reduce with a for-in loop.

This has a 2x improvement on ops/s.

JS Benchmark:

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 3:12pm

@rd-xx
Copy link

rd-xx commented May 19, 2024

This is huge. I'm seeing a 3.6x improvement on M1 Pro 🙌

Such a shame this library is not being maintained anymore

@aleclarson
Copy link

Hi @Kinbaum, your fix is available in radashi@beta today (see #13). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄

@rd-xx You are invited as well!

@rd-xx
Copy link

rd-xx commented Jun 28, 2024

Hi @aleclarson, thank you very much for your work. I had no idea radash had an active fork, I will be making the switch soon enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants