Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance BatchRequestCore (and implement node-side equivalent) #243

Open
gavin-norman-sociomantic opened this issue Jan 17, 2018 · 10 comments

Comments

@gavin-norman-sociomantic

The existing request core is fairly minimal. I'm sure there's a lot more common code that could be added (basic fiber implementations, for example).

Ditto for the node side of the equation (where no core code exists atm).

@gavin-norman-sociomantic
Copy link
Author

This could include the whole record batch management, as well (on both sides).

@gavin-norman-sociomantic
Copy link
Author

It should use the new record batcher, too.

@gavin-norman-sociomantic
Copy link
Author

Should probably include sociomantic-tsunami/dlsproto#84 by default.

@nemanja-boric-sociomantic
Copy link
Contributor

nemanja-boric-sociomantic commented May 29, 2018

Btw, I the code pretty much ready, I'll clean it up and submit a PR in the next few days. I've successfully converted DMQ's Consume request and DLS's GetRange reqeuest to use it.

@nemanja-boric-sociomantic
Copy link
Contributor

Oh, yes, I think it should include that feature by default (it also includes double-buffering).

@gavin-norman-sociomantic
Copy link
Author

Should use https://github.com/sociomantic-tsunami/swarm/blob/v4.x.x/src/swarm/neo/util/Batch.d internally (at the request's option?).

@nemanja-boric-sociomantic
Copy link
Contributor

Feature: extend finished notification to indicate the number of nodes where the request finished successfully/with an error.

@nemanja-boric-sociomantic
Copy link
Contributor

@gavin-norman-sociomantic
Copy link
Author

Btw, I the code pretty much ready, I'll clean it up and submit a PR in the next few days. I've successfully converted DMQ's Consume request and DLS's GetRange reqeuest to use it.

:(

@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: v6.0.0, v5.5.0 May 7, 2019
@gavin-norman-sociomantic
Copy link
Author

Moved to v5.5.0.

@Geod24 Geod24 removed this from the v5.5.0 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants