Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt requests to use new request handler framework from swarm #78

Closed
9 tasks done
gavin-norman-sociomantic opened this issue Dec 18, 2017 · 5 comments
Closed
9 tasks done

Comments

@gavin-norman-sociomantic
Copy link

gavin-norman-sociomantic commented Dec 18, 2017

Swarm v4.5.0 includes a PR to convert the global status codes into a supported/not supported code.

All requests in dhtproto neo should be updated to use this system, rather than the old approach of an unsupported / ok / error status code. (The idea is that the initial status code purely indicates whether the node supports the request or not, and all actual errors are handled by messages that can be passed at any time, not just at request initialisation.)

@gavin-norman-sociomantic gavin-norman-sociomantic added this to the neo-alpha-5 milestone Dec 18, 2017
@gavin-norman-sociomantic
Copy link
Author

One commit in the PR gives an example of adapting a request: sociomantic-tsunami/swarm@96a2c38

@gavin-norman-sociomantic
Copy link
Author

This is a protocol change. Existing requests could be adapted via a new request version, but as we're in alpha still, backwards compatibility is of low importance. I'll simply do this as a breaking change.

gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
@gavin-norman-sociomantic
Copy link
Author

#90 adapts Get, Put, GetChannels, Mirror.

I'll do GetHashRange and GetAll as part of #70 and #38.

gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 8, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 9, 2018
gavin-norman-sociomantic pushed a commit to gavin-norman-sociomantic/dhtproto that referenced this issue Jan 10, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic changed the title Adapt requests to use new SupportedCode from swarm Adapt requests to use new request handler framework from swarm Jan 26, 2018
@gavin-norman-sociomantic
Copy link
Author

All done except GetAll. Waiting until sociomantic-tsunami/swarm#243 is implemented.

@gavin-norman-sociomantic
Copy link
Author

GetAll was actually done in aacd1fa, as part of the major submodule update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant