-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt requests to use new request handler framework from swarm #78
Comments
One commit in the PR gives an example of adapting a request: sociomantic-tsunami/swarm@96a2c38 |
This is a protocol change. Existing requests could be adapted via a new request version, but as we're in alpha still, backwards compatibility is of low importance. I'll simply do this as a breaking change. |
All done except GetAll. Waiting until sociomantic-tsunami/swarm#243 is implemented. |
GetAll was actually done in aacd1fa, as part of the major submodule update. |
Swarm v4.5.0 includes a PR to convert the global status codes into a supported/not supported code.
All requests in dhtproto neo should be updated to use this system, rather than the old approach of an unsupported / ok / error status code. (The idea is that the initial status code purely indicates whether the node supports the request or not, and all actual errors are handled by messages that can be passed at any time, not just at request initialisation.)
The text was updated successfully, but these errors were encountered: