-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Masstransit to handle events #168
Changes from all commits
22cc866
9737e45
7414669
62bd9a3
5f84cf6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,7 @@ | ||
MYSQL_SERVER=localhost | ||
MYSQL_DATABASE=techchallenge | ||
MYSQL_PORT=3306 | ||
MYSQL_USERID=techchallenge | ||
MYSQL_PASSWORD=techchallengeFIAP | ||
MercadoPago_WebhookSecret=1231231231232 | ||
MercadoPago_AccessToken=APP_USR- | ||
MercadoPago_NotificationUrl=https://a42d-mercadopago | ||
HybridCache_Expiration=01:00:00 | ||
HybridCache_LocalCacheExpiration=01:00:00 | ||
HybridCache_Flags=DisableDistributedCache | ||
JwtOptions__Issuer=https://localhost:7000 | ||
JwtOptions__Audience=https://localhost:7000 | ||
JwtOptions__ExpirationSeconds=300 | ||
JwtOptions__UseAccessToken=false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"branches": [ | ||
"main", | ||
"semantic-release-plugins" | ||
], | ||
Comment on lines
+2
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Remove "semantic-release-plugins" from release branches The "semantic-release-plugins" branch doesn't exist in the repository, and there's no historical context justifying its inclusion in the release configuration. This appears to be an unintended inclusion that should be removed to prevent potential issues with semantic releases.
🔗 Analysis chainVerify the purpose of "semantic-release-plugins" branch The inclusion of "semantic-release-plugins" as a release branch seems unusual. This appears to be a feature or temporary branch rather than a long-term release branch. Consider limiting releases to the "main" branch only, unless there's a specific reason for maintaining multiple release branches. Run the following script to check the branch usage: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if semantic-release-plugins branch exists and its commit history
# Check branch existence and last commit
git branch -a | grep semantic-release-plugins
git log --oneline semantic-release-plugins 2>/dev/null || echo "Branch not found"
Length of output: 135 Script: #!/bin/bash
# Let's check the git history to understand the context of this configuration
git log --all --full-history -- .releaserc
# Also check if there are any related pull requests
gh pr list --state all --search "semantic-release"
Length of output: 440 |
||
"tagFormat": "v${version}", | ||
"plugins": [ | ||
"@semantic-release/commit-analyzer", | ||
"@semantic-release/release-notes-generator", | ||
"@semantic-release/github", | ||
[ | ||
"@semantic-release/exec", | ||
{ | ||
"verifyReleaseCmd": "echo v${nextRelease.version} > VERSION" | ||
} | ||
] | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for version extraction.
The version extraction step should validate the semantic-release output to prevent potential failures.
📝 Committable suggestion
🧰 Tools
🪛 actionlint
184-184: shellcheck reported issue in this script: SC2086:info:3:28: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint
[warning] 182-182: wrong indentation: expected 4 but found 6
(indentation)