fix: CLI update & download [IDE-123][IDE-124] #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bastiandoetsch
changed the title
| } | ||
|
|
||
| fun scan() { | ||
| taskQueue.run(object : Task.Backgroundable(project, "Snyk: initializing...", true) { | ||
| override fun run(indicator: ProgressIndicator) { | ||
| // FIXME: this should be using content roots instead of basePath |
Check warning
Code scanning / detekt
Flags a forbidden comment. Warning
- only start-up after download/update - only start-up one instance
bastiandoetsch
force-pushed
the
fix/IDE-124_fix-CLI-update
branch
from
86003e2
to
fef3ebc
Compare
- automatic downloads setting is now checked centrally - downloads should be done via the task service - SnykCliAuthenticationService now uses the task service, too - fixed a potential NPE in SnykTaskQueueService - removed superfluous test - adjusted mocking
bastiandoetsch
force-pushed
the
fix/IDE-124_fix-CLI-update
branch
from
fef3ebc
to
98fbf0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have received several reports that CLI updates under Windows don't work. This is due to a file lock.
This PR ensures two things:
snyk language-serverin the background.Checklist
Screenshots / GIFs
Opened 5 projects, and verified only one snyk-win.exe process:
