Support events on buttons/links/forms in ShadowDOMs #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DOM events on elements within Custom Components/ShadowRoots trigger against the
document
, thetarget
is set to the Custom Element/shadow host rather than the actual element that caused the event.This change adds support to the from/button/link tracking plugins to detect when this occurs, and use the first element from the Event's
composedPath
instead of thetarget
. This enables them to see the actual even target and fire correctly in this scenario.For the Form tracker, only
focus
events are consideredcomposed
, sochange
andsubmit
events don't actually get reported outside the shadow DOM. As a workaround, when thefocus
events occur, if enabled the change/submit event listeners are bound directly to the form (or field if it has no associated form) rather than just thedocument
.