Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use capture-phase listeners for button click tracking #1348

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Use capture-phase listeners for button click tracking #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...snowplow/browser-plugin-button-click-tracking/button-plugin-capture_2024-10-04-03-17.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-plugin-button-click-tracking",
"comment": "Use capture-phase event listeners",
"type": "none"
}
],
"packageName": "@snowplow/browser-plugin-button-click-tracking"
}
4 changes: 2 additions & 2 deletions plugins/browser-plugin-button-click-tracking/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function enableButtonClickTracking(
};

const addClickListener = () => {
document.addEventListener('click', _listeners[trackerId]);
document.addEventListener('click', _listeners[trackerId], true);
};

if (_trackers[trackerId]?.sharedState.hasLoaded) {
Expand All @@ -83,7 +83,7 @@ export function enableButtonClickTracking(
export function disableButtonClickTracking() {
for (const trackerId in _trackers) {
if (_listeners[trackerId]) {
document.removeEventListener('click', _listeners[trackerId]);
document.removeEventListener('click', _listeners[trackerId], true);
}
}
}
Expand Down
Loading