Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E testIdentifier randomness between test retries #1228

Merged

Conversation

igneel64
Copy link
Contributor

Small fix to allow e2e test identifiers to add some randomness between test retries in the identifiers.

Currently tests that go into further retries will fail as the testIdentifier (translating this to appId in the events) will be the same.

@bundlemon
Copy link

bundlemon bot commented Aug 16, 2023

BundleMon

Files added (6)
Status Path Size Limits
libraries/browser-tracker-core/dist/index.mod
ule.js
+25.19KB 26KB / +10%
trackers/javascript-tracker/dist/sp.js
+24.12KB 25KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+14.8KB 15KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+14.64KB 15KB / +10%
libraries/tracker-core/dist/index.module.js
+13.35KB 15KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.51KB 5KB / +10%

Total files change +95.6KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

@greg-el greg-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igneel64 igneel64 changed the base branch from master to release/3.15.0 August 23, 2023 08:17
@igneel64 igneel64 merged commit 9d65a9b into release/3.15.0 Aug 23, 2023
2 checks passed
@igneel64 igneel64 deleted the fix/proper-test-identifier-between-e2e-retries branch August 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants