-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser-plugin-ga-cookies to include options for Google Analytics 4 cookies #1226
Merged
igneel64
merged 1 commit into
release/3.17.0
from
feature/1225-ga-cookies-plugin-ga4-cookies-addition
Nov 14, 2023
Merged
Update browser-plugin-ga-cookies to include options for Google Analytics 4 cookies #1226
igneel64
merged 1 commit into
release/3.17.0
from
feature/1225-ga-cookies-plugin-ga4-cookies-addition
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For JS tracker V4 we can change the defaults to GA4 cookies and have UA only as opt-in because it will be deprecated for all customers. |
BundleMonFiles added (6)
Total files change +95.83KB 0% Final result: ✅ View report in BundleMon website ➡️ |
jethron
reviewed
Aug 9, 2023
igneel64
force-pushed
the
feature/1225-ga-cookies-plugin-ga4-cookies-addition
branch
from
August 14, 2023 14:18
efcc381
to
654a1dc
Compare
jethron
reviewed
Aug 15, 2023
igneel64
force-pushed
the
feature/1225-ga-cookies-plugin-ga4-cookies-addition
branch
2 times, most recently
from
August 15, 2023 21:25
d1e2517
to
b4cd43f
Compare
jethron
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
igneel64
force-pushed
the
feature/1225-ga-cookies-plugin-ga4-cookies-addition
branch
from
August 18, 2023 08:50
b4cd43f
to
76e4487
Compare
igneel64
force-pushed
the
feature/1225-ga-cookies-plugin-ga4-cookies-addition
branch
from
August 18, 2023 09:23
76e4487
to
735f4e3
Compare
igneel64
deleted the
feature/1225-ga-cookies-plugin-ga4-cookies-addition
branch
November 14, 2023 12:36
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows for the
browser-plugin-ga-cookies
to collect Google Analytics 4 cookie values.Up to now the plugin did not accept any options and only collected a standard set of values for the schema
iglu:com.google.analytics/cookies/jsonschema/1-0-0
.This PR adds the capability for the plugin to collect Google Analytics 4 cookies without breaking the previous implementation. With the options, you can specifiy which set of cookies you want to collect and since the GA4 session cookie name is based on a parameter called
container-id
, the client should input this as well to collect the correct value.E.g.
After collecting the GA4 session cookie, the customer will be able to extract information such as the session id and session index from the cookie.
New schema for GA4 cookies:
In the case of cookiePrefix/es N, N number of GA4 cookie contexts will be attached.