Filter out repeated seek and volume change events happening when user holds down the player controls (close #1218) #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1218
This PR adds the ability to filter out repeated seek and volume change events in the media plugin that occur frequently when the user is scrubbing the controls in players (e.g., in the Vimeo or HTML5 players).
The algorithm to filter out the events is very simple – if a seek event is tracked, it is kept in a buffer (not tracked) until an event other than a seek event is tracked or until the media tracking ends (
endMediaTracking
is called).So if the following events are tracked:
By filtering events, the result will be:
Filtering out repeated seek and volume change events is enabled by default, but it is possible to disable as follows:
or like this: