Add Vimeo tracking plugin (close #1156) #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
from
8e22643
to
94a0c52
Compare
greg-el
commented
Jun 22, 2023
| videoTitle: await player.getVideoTitle(), | ||
| videoWidth: await player.getVideoWidth(), | ||
| videoHeight: await player.getVideoHeight(), | ||
| // 'getVideoUrl' can fail due to privacy settings |
There was a problem hiding this comment.
All Vimeo getters return a Promise, but it's very difficult to tell if they all can actually fail. The getters all internally run this method but it's hard to track it through to where a failure could occur. Anecdotally, the only method I've had fail is getVideoUrl, but it might be worth wrapping more of these getters in the tryVimeoPromise so we can soft fail on missing data for optional properties.
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
2 times, most recently
from
2603701
to
d94e865
Compare
BundleMonFiles added (6)
Total files change +95.15KB 0% Final result: ✅ View report in BundleMon website ➡️ |
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
13 times, most recently
from
3c3a83c
to
0cd4d94
Compare
plugins/browser-plugin-vimeo-tracking/src/mediaPluginBinding.ts
Outdated
Show resolved
Hide resolved
plugins/browser-plugin-vimeo-tracking/src/mediaPluginBinding.ts
Outdated
Show resolved
Hide resolved
plugins/browser-plugin-vimeo-tracking/src/mediaPluginBinding.ts
Outdated
Show resolved
Hide resolved
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
from
0d534e5
to
6557d0b
Compare
matus-tomlein
approved these changes
Jun 30, 2023
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
2 times, most recently
from
6dd2a8a
to
7be7fae
Compare
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
3 times, most recently
from
40b6ee6
to
63cd3f0
Compare
greg-el
force-pushed
the
issue/1156-vimeo_plugin
branch
from
63cd3f0
to
7cb772b
Compare
greg-el
added a commit
that referenced
this pull request
Aug 10, 2023
greg-el
added a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin to automatically track Vimeo videos, utilising the Snowplow Media plugin.