Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the idService option to the tracker configuration (close #1185) #1186

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add the idService option to the tracker configuration (close #1185) #1186

merged 1 commit into from
Aug 25, 2023

Conversation

igneel64
Copy link
Contributor

@igneel64 igneel64 commented May 11, 2023 •
edited
Loading

This was first released in a dev version.
More in #1185

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label May 11, 2023
@igneel64 igneel64 requested a review from jethron May 11, 2023 20:21
@igneel64 igneel64 removed the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label May 11, 2023
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch 3 times, most recently from 9aa1001 to 2491436 Compare May 12, 2023 07:26
@bundlemon
Copy link

bundlemon bot commented May 12, 2023 •
edited
Loading

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +25.32KB 26KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +24.18KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +14.86KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.7KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.35KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.51KB 5KB / +10%

Total files change +95.92KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

jethron
jethron reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@jethron jethron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong about the localStorage thing, can you sanity check?

libraries/browser-tracker-core/src/tracker/out_queue.ts Outdated Show resolved Hide resolved
libraries/browser-tracker-core/src/tracker/out_queue.ts Outdated Show resolved Hide resolved
libraries/browser-tracker-core/src/tracker/out_queue.ts Outdated Show resolved Hide resolved
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch from 2491436 to b43a776 Compare May 15, 2023 15:04
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch from b43a776 to 463ef5a Compare May 16, 2023 07:05
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch from 463ef5a to 2cadf0b Compare May 16, 2023 12:18
matus-tomlein
matus-tomlein approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matus-tomlein
matus-tomlein approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

matus-tomlein
matus-tomlein approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jethron
jethron approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@jethron jethron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing that probably doesn't matter. LGTM!

libraries/browser-tracker-core/src/tracker/out_queue.ts Show resolved Hide resolved
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch from 2cadf0b to dae705f Compare July 4, 2023 07:41
@igneel64 igneel64 changed the base branch from master to release/3.15.0 August 23, 2023 08:19
@igneel64 igneel64 force-pushed the feature/1185-id-service-option branch from dae705f to 1c611f0 Compare August 23, 2023 09:04
@igneel64 igneel64 merged commit 062ff7d into release/3.15.0 Aug 25, 2023
2 checks passed
@igneel64 igneel64 deleted the feature/1185-id-service-option branch August 25, 2023 08:55
igneel64 added a commit that referenced this pull request Aug 28, 2023
@igneel64
Add the idService option to the tracker configuration (close #1185)
0421bb6 
#1186
igneel64 added a commit that referenced this pull request Sep 13, 2023
@igneel64
Add the idService option to the tracker configuration (close #1185)
168e9fc 
#1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

@jethron jethron jethron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igneel64 @matus-tomlein @jethron @snowplowcla