Skip to content

Commit

Permalink
Let user pass id in rather than generating UUID
Browse files Browse the repository at this point in the history
  • Loading branch information
greg-el committed Oct 7, 2024
1 parent 287f738 commit 73e5e72
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion plugins/browser-plugin-media-tracking/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type Config = {
video: string | HTMLMediaElement;
label?: string;
} & CommonMediaEventProperties &
Omit<MediaTrackingConfiguration, 'id' | 'player'>;
Omit<MediaTrackingConfiguration, 'player'>;

export interface StringConfig extends Config {
video: string;
Expand Down
3 changes: 1 addition & 2 deletions plugins/browser-plugin-media-tracking/src/player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ function htmlContext(el: HTMLMediaElement): (() => SelfDescribingJson)[] {
}

export function setUpListeners(config: ElementConfig) {
const { video } = config;
const id = uuidv4();
const { id, video } = config;

startMediaTracking({
...config,
Expand Down

0 comments on commit 73e5e72

Please sign in to comment.