Skip to content

Commit

Permalink
Allow for web vitals plugin in javascript tracker configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
igneel64 committed Aug 31, 2023
1 parent de97c3b commit 5f908c9
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/javascript-tracker",
"comment": "Allow for web vitals plugin in javascript tracker configuration",
"type": "none"
}
],
"packageName": "@snowplow/javascript-tracker"
}
4 changes: 4 additions & 0 deletions common/config/rush/browser-approved-packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@
"name": "@snowplow/browser-plugin-vimeo-tracking",
"allowedCategories": [ "trackers" ]
},
{
"name": "@snowplow/browser-plugin-web-vitals",
"allowedCategories": [ "trackers" ]
},
{
"name": "@snowplow/browser-plugin-youtube-tracking",
"allowedCategories": [ "trackers" ]
Expand Down
2 changes: 2 additions & 0 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common/config/rush/repo-state.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
{
"pnpmShrinkwrapHash": "a8b7bdefbe86b839e0c359de02cae9c4ccc90039",
"pnpmShrinkwrapHash": "2edf95670021b7b1f18241f12d37598efbd4a2e9",
"preferredVersionsHash": "bf21a9e8fbc5a3846fb05b4fa0859e0917b2202f"
}
3 changes: 2 additions & 1 deletion trackers/javascript-tracker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"@snowplow/tracker-core": "workspace:*",
"tslib": "^2.3.1",
"@snowplow/browser-plugin-enhanced-consent": "workspace:*",
"@snowplow/browser-plugin-privacy-sandbox": "workspace:*"
"@snowplow/browser-plugin-privacy-sandbox": "workspace:*",
"@snowplow/browser-plugin-web-vitals": "workspace:*"
},
"devDependencies": {
"@ampproject/rollup-plugin-closure-compiler": "~0.27.0",
Expand Down
8 changes: 7 additions & 1 deletion trackers/javascript-tracker/src/features.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import * as EnhancedConsent from '@snowplow/browser-plugin-enhanced-consent';
import * as SnowplowMedia from '@snowplow/browser-plugin-media';
import * as VimeoTracking from '@snowplow/browser-plugin-vimeo-tracking';
import * as PrivacySandbox from '@snowplow/browser-plugin-privacy-sandbox';
import * as WebVitals from '@snowplow/browser-plugin-web-vitals';

/**
* Calculates the required plugins to intialise per tracker
Expand Down Expand Up @@ -208,11 +209,16 @@ export function Plugins(configuration: JavaScriptTrackerConfiguration) {
const { VimeoTrackingPlugin, ...apiMethods } = VimeoTracking;
activatedPlugins.push([VimeoTrackingPlugin(), apiMethods]);
}

if (plugins.privacySandbox) {
const { PrivacySandboxPlugin, ...apiMethods } = PrivacySandbox;
activatedPlugins.push([PrivacySandboxPlugin(), apiMethods]);
}

if (plugins.webVitals) {
const { WebVitalsPlugin, ...apiMethods } = WebVitals;
activatedPlugins.push([WebVitalsPlugin(), apiMethods]);
}

return activatedPlugins;
}
1 change: 1 addition & 0 deletions trackers/javascript-tracker/tracker.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ export const enhancedConsent = false;
export const snowplowMedia = false;
export const vimeoTracking = false;
export const privacySandbox = false;
export const webVitals = false;
1 change: 1 addition & 0 deletions trackers/javascript-tracker/tracker.lite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ export const enhancedConsent = false;
export const snowplowMedia = false;
export const vimeoTracking = false;
export const privacySandbox = false;
export const webVitals = false;
1 change: 1 addition & 0 deletions trackers/javascript-tracker/tracker.test.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@ export const enhancedConsent = false;
export const snowplowMedia = true;
export const vimeoTracking = true;
export const privacySandbox = false;
export const webVitals = false;

0 comments on commit 5f908c9

Please sign in to comment.