Add missing flush API (close #679) #684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscwilson
force-pushed
the
bug/expose_flush
branch
from
59b8c63
to
d80f406
Compare
|
Anything I can do to help get this merged? |
|
After discussion within the team, we've decided to backburner this PR for now. The way the Emitter works is different between the Android and iOS trackers; we have plans to eventually update the Android code. For now, we're concerned that this change is too naive and could lead to unexpected behaviour - that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #679
Exposes the Emitter
flush()method