Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.23.0 #206

Merged
merged 3 commits into from
May 8, 2024
Merged

Release 0.23.0 #206

merged 3 commits into from
May 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2024

Created by Github Actions

Snowplow users commonly use schemas with no nested fields. Previously,
we were creating a string column and loading the string field `{}`. But
there is no benefit to loading this redundant data.

By omitting a column for these schemas, it means we support schema
evolution if the user ever adds a nested field to the empty schema.

For empty schemas with `additionalProperties: true` we retain the old
behaviour of loading the original JSON as a string.
In modern snowplow loaders we have already switched to using Vector when
manipulating data structures. We use vector because we commonly need to
join together fields from different shcmeas.

But even the new loader code still has lots of `list.toVector`. If we
change to Vector in schema-ddl then we can eliminate a lot of those
unnecessary conversions.
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@istreeter istreeter merged commit 414a2d7 into master May 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants