initial suggestion minor tests completed sucessfully #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnessnowplow
force-pushed
the
macro_update_PE-6573
branch
12 times, most recently
from
dfea5ec
to
718d779
Compare
agnessnowplow
force-pushed
the
macro_update_PE-6573
branch
from
718d779
to
7c36d72
Compare
OscarSnowPlow
requested review from
ilias1111 and
agnessnowplow
and removed request for
a team
|
I need to change the base branch from main to one of the release branches which one should this be? |
OscarSnowPlow
commented
Oct 7, 2024
20 tasks
OscarSnowPlow
changed the base branch from
main
to
release/snowplow-utils/0.17
agnessnowplow
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this?
Related Tickets & Documents
https://snplow.atlassian.net/jira/software/c/projects/PE/boards/50?assignee=712020%3Ab916e641-2c6f-4de9-82f6-d175e2e15bee&selectedIssue=PE-6573
Updated the macro to stop an error message occurring when a specific scenario appears in the attribution model.
This change modifies the macro adding a new argument. The argument is a boolean true or false which is an optional argument which automatically sets to false. If I change the argument is set to false the macro runs as it did previously, but when set to true instead of outputting a high date time stamp ('9999-01-01','999-01-02) it outputs ('0000-01-01','0000-01-02'.
note.
there was an issue with testing because of a dbt update which required me seeking some help from Agnes to change the version of testing's dbt. without the dbt vewrsion issue the code passed the test
Checklist
Added tests?
Added to documentation?