-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the base macro (where possible) #36
Merged
emielver
merged 1 commit into
release/snowplow-normalize/0.3.3
from
feature/PE-5501/base-macro
Sep 29, 2023
Merged
Implement the base macro (where possible) #36
emielver
merged 1 commit into
release/snowplow-normalize/0.3.3
from
feature/PE-5501/base-macro
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Coverage Report - Python 3.10
Python 3.10 Test Results
|
Test Coverage Report - Python 3.7
Python 3.7 Test Results
|
Test Coverage Report - Python 3.9
Python 3.9 Test Results
|
Test Coverage Report - Python 3.8
Python 3.8 Test Results
|
rlh1994
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a suggestion about an improvement we could maybe make
models/base/scratch/snowplow_normalize_base_events_this_run.sql
Outdated
Show resolved
Hide resolved
emielver
force-pushed
the
feature/PE-5501/base-macro
branch
from
September 29, 2023 10:10
677dae6
to
02a8702
Compare
emielver
added a commit
that referenced
this pull request
Sep 29, 2023
emielver
added a commit
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Add the base macro, simplify the models
Checklist