Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the base macro (where possible) #36

Merged

Conversation

emielver
Copy link
Contributor

Description & motivation

Add the base macro, simplify the models

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have raised a documentation PR if applicable (Link here if required)

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Test Coverage

Test Coverage Report - Python 3.10
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497% 

Python 3.10 Test Results

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 4.153s ⏱️

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Test Coverage

Test Coverage Report - Python 3.7
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497% 

Python 3.7 Test Results

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 3.909s ⏱️

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Test Coverage

Test Coverage Report - Python 3.9
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497% 

Python 3.9 Test Results

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 4.992s ⏱️

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Test Coverage

Test Coverage Report - Python 3.8
FileStmtsMissCoverMissing
snowplow_model_gen_funcs.py144497%115–116, 202, 256
TOTAL144497% 

Python 3.8 Test Results

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 4.195s ⏱️

Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a suggestion about an improvement we could maybe make

@emielver emielver merged commit 4ecad05 into release/snowplow-normalize/0.3.3 Sep 29, 2023
7 checks passed
@emielver emielver deleted the feature/PE-5501/base-macro branch September 29, 2023 10:15
@emielver emielver restored the feature/PE-5501/base-macro branch September 29, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants