SNOW-805980: Show Pagination POC at JDBC driver level #1502
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
| // if no more results are found, now trigger pagination call | ||
| // Note: In actuality, instead of show tables command, a pagination call with a token will be invoked here. | ||
| // For now, a show command is invoked. | ||
| ResultSet resultSet1 = executeAndReturnEmptyResultIfNotFound(statement, "show /* JDBC:DatabaseMetaData.getTables() */ tables in schema \"JDBC_DB1\".\"JDBC_SCHEMA11\" limit 1 from '" + lastTable + "'", GET_TABLES); |
There was a problem hiding this comment.
This won't work everytime, if table list change after getting first set of values. Do we have any design doc or something like that? Let's review that before you make code changes. If we don't have any doc, please start a doc first.
There was a problem hiding this comment.
+1 to what Ilesh said. It would be great to see a one pager that first outlines what is it that we're trying to achieve and how we're thinking of doing it. Looking at code is great but it does not give the big picture.
|
@sfc-gh-abakare are you still working on it? If not, please close the PR for now. |
Overview
THIS IS A POC won't be merged into main.
SNOW-805980
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
This is an POC for driver level SHOW commands pagination.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist