Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-780605: Better handle resource closing in testHTAPOptimizations #1500

Merged
merged 1 commit into from
Aug 28, 2023
Merged

SNOW-780605: Better handle resource closing in testHTAPOptimizations #1500

merged 1 commit into from
Aug 28, 2023

Conversation

sfc-gh-pfus
Copy link
Contributor

@sfc-gh-pfus sfc-gh-pfus commented Aug 25, 2023 •
edited
Loading

SNOW-780605 - before, if test failed on any assertions, account parameter would not be unset. Also, resources would not be closed.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-780605-htap-optimisations-test-finally branch from b0bd858 to f5a98e7 Compare August 25, 2023 07:22
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review August 25, 2023 09:42
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner August 25, 2023 09:42
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-780605-htap-optimisations-test-finally branch from f5a98e7 to 22e7f94 Compare August 25, 2023 10:01
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 1e92087 into master Aug 28, 2023
12 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-780605-htap-optimisations-test-finally branch August 28, 2023 05:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz