Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep existing labels on spaces and proposals #4917

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ChaituVR
Copy link
Member

Related to https://github.com/snapshot-labs/workflow/issues/143

Summary

  • Keep existing labels on space settings update
  • Keep existing labels on proposal update

How to test

  1. Go to any space with labels (or add labels on v2)
  2. Edit space settings, should keep the labels space
  3. Create a proposal on v2 with labels
  4. Edit proposal on v1, should keep the labels on proposal

Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 3564257 into master Oct 17, 2024
6 of 7 checks passed
@ChaituVR ChaituVR deleted the fix-keep-existing-labels branch October 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants