Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: walletconnect options: move methods to optionalMethods #4903

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: walletconnect options: move methods to optionalMethods #4903

merged 1 commit into from
Oct 2, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 2, 2024

Summary

Same fix as snapshot-labs/sx-monorepo#745

  • moving all methods into optional methods

How to test

  1. Go to http://localhost:8081/#/delegate/apecoin.eth
  2. Connect to your safe with walletconnect (with new changes make sure to disconnect if you are already connected)
  3. Delegete or remove delegate
  4. Before fix. it will show error: "unknown account"
  5. After fix: it will open transaction modal on Safe

@ChaituVR ChaituVR merged commit 15de403 into master Oct 2, 2024
6 checks passed
@ChaituVR ChaituVR deleted the wc-optional-methods branch October 2, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@wa0x6e wa0x6e Awaiting requested review from wa0x6e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack