Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent previously deleted ENS from being used again #4519

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Jan 18, 2024

Summary

Closes: #4516

Prevent an ENS used by a deleted space to be used again for creating a new space.

How to test

  1. Connect with a wallet linked to a deleted space
  2. Go to http://localhost:8080/#/setup?step=1
  3. It should list all your wallet's available ENS
  4. The ENS used by the deleted space should appear, but can not be used to create a new space

With only valid domains, should list the ENS as before

localhost_8080_ (2)

With at least one unavailable ENS domains:

localhost_8080_ (1)

With multiple unavailable ENS domains:

localhost_8080_ (3)

To-Do

@wa0x6e
Copy link
Collaborator Author

wa0x6e commented Jan 24, 2024

Functionality wise, it is ready.

UX/UI have room for improvement, current unavailable domains should be differentiated more clearly, like in another color, or in another section, and should not be clickable (currently redirecting to external website without warning) (UI updated)

@samuveth
Copy link
Contributor

Doesn't work for me, the page listing the spaces seems buggy. Is this ready?

@wa0x6e
Copy link
Collaborator Author

wa0x6e commented Jan 30, 2024

Doesn't work for me, the page listing the spaces seems buggy. Is this ready?

Yes, it is ready, what do you see ? If testing with you local hub, it should be on latest version to support deleted domains fetching

Copy link
Contributor

@samuveth samuveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@samuveth samuveth merged commit 9c94fe8 into master Jan 31, 2024
5 checks passed
@samuveth samuveth deleted the fix-4516 branch January 31, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] - Prevent creation of space from previously delete ENS
2 participants