Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore expired ENS domains on space creation #4424

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: Ignore expired ENS domains on space creation #4424

merged 1 commit into from
Dec 2, 2023

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Dec 2, 2023

Issue:

Right now we show expired domains while space creation, it is confusing

How to test:

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
snapshot ✅ Ready (Inspect) Visit Preview Dec 2, 2023 0:14am

@ChaituVR ChaituVR requested a review from wa0x6e December 2, 2023 12:19
wa0x6e
wa0x6e approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit c6fe465 into master Dec 2, 2023
8 checks passed
@ChaituVR ChaituVR deleted the ignore-expired-domains branch December 2, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e