feat: add og subgraph queries #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daywiss is attempting to deploy a commit to the snapshot Team on Vercel. A member of the Team first needs to authorize it. |
daywiss
commented
Jul 5, 2023
| proposalHash: proposalHash, | ||
| proposalTxHash: event.transactionHash, | ||
| logIndex: event.logIndex | ||
| }; |
There was a problem hiding this comment.
this was just re-formatted to use async await
daywiss
commented
Jul 5, 2023
| ); | ||
| } | ||
| ) | ||
| ]); |
There was a problem hiding this comment.
we can remove all events now from the graph function call now that we have OG subgraphs
daywiss
force-pushed
the
david/uma-1618-add-og-subgraph-calls-to-osnap
branch
from
d1ab7bd
to
cd23095
Compare
|
we are making an update to the subgraphs, which will require some changes to this pr |
daywiss
force-pushed
the
david/uma-1618-add-og-subgraph-calls-to-osnap
branch
from
cd23095
to
4800d21
Compare
daywiss
commented
Jul 6, 2023
src/plugins/safeSnap/constants.ts
Outdated
| }, | ||
| { | ||
| network: '42161', | ||
| name: 'OptimisticGovernor', | ||
| subgraph: | ||
| 'https://api.thegraph.com/subgraphs/name/md0x/arbitrum-optimistic-governor' | ||
| 'https://api.thegraph.com/subgraphs/name/umaprotocol/arbitrum-optimistic-governor' |
There was a problem hiding this comment.
adding production endpoints
daywiss
commented
Jul 6, 2023
| return 'proposal-approved'; | ||
|
|
||
| // Proposal is approved if it has been settled without a disputer and hasn't been executed. | ||
| if (assertionEvent.isSettled && !proposalExecuted) return 'proposal-approved'; | ||
| if (assertionEvent?.isSettled && !proposalExecuted) |
There was a problem hiding this comment.
ensuring this exists
Signed-off-by: david <[email protected]>
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/uma-1618-add-og-subgraph-calls-to-osnap
branch
from
78f8586
to
72be9f4
Compare
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/uma-1618-add-og-subgraph-calls-to-osnap
branch
from
c289e8e
to
f606942
Compare
Signed-off-by: david <[email protected]>
daywiss
force-pushed
the
david/uma-1618-add-og-subgraph-calls-to-osnap
branch
from
ea13d14
to
e0f1ff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
we recently deployed an OG subgraph. We want to add queries to it to further optimize calls when requesting historical data.
Fixes #
Changes
(Briefly describe the changes made in this PR)
How to test
(Explain how the changes can be tested, including any required setup steps)
see that there is no warning in console Error querying module details from the graph. this means it used the subgraph function successfully. it shows that it has been executed.
To-Do
(List any outstanding tasks be addressed before or after this PR is merged)
Self-review checklist
Additional notes or considerations
(Include any other relevant information or context that may be helpful for the reviewer)