chore: add lint to ci (#1034)

* chore: fix types warning * chore: fix lint * chore: update to typescript 5 * chore: raise error on lint error on CI * chore: `lint` task should raise an error * chore: bump compilation target to es6 * v0.11.39 --------- Co-authored-by: Chaitanya <[email protected]>
snapshot-labs · Jul 11, 2024 · 710c50c · 710c50c
1 parent 63f74f1
commit 710c50c
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 45 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -1,28 +1,8 @@
 name: Lint
-on:
- workflow_dispatch:
- schedule:
-   - cron: 0 10 * * 0
+
+on: [push]
 
 jobs:
   lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
-        with:
-          node-version: '14.x'
-      - name: Run lint script
-        run: |
-          npm ci
-          npm run lint
-      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3
-        with:
-            commit-message: Automated lint
-            title: Automated lint
-            body: |
-              - Changes from lint script
-  
-              Auto-generated by Github Actions
-            branch: automated-lint
+    uses: snapshot-labs/actions/.github/workflows/lint.yml@main
+    secrets: inherit
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -21,7 +21,6 @@ jobs:
           yarn install --frozen-lockfile
           yarn build
           yarn test:once --coverage
-          yarn lint
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v3
         with:

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@snapshot-labs/snapshot.js",
-  "version": "0.11.38",
+  "version": "0.11.39",
   "repository": "snapshot-labs/snapshot.js",
   "license": "MIT",
   "main": "dist/snapshot.cjs.js",
@@ -45,7 +45,7 @@
     "rollup-plugin-terser": "^7.0.0",
     "rollup-plugin-typescript2": "^0.27.0",
     "ts-node": "^10.9.2",
-    "typescript": "^3.8.3",
+    "typescript": "^5.0.0",
     "vitest": "^0.33.0"
   },
   "scripts": {
@@ -54,7 +54,9 @@
     "test": "vitest",
     "test:once": "vitest run",
     "dev": "rollup -c -w",
-    "lint": "eslint . --ext .ts --fix",
+    "lint": "eslint . --ext .ts",
+    "lint:fix": "yarn lint --fix",
+    "typecheck": "tsc --noEmit",
     "prepublishOnly": "yarn build"
   },
   "engines": {

diff --git a/src/sign/eip1271.ts b/src/sign/eip1271.ts
@@ -19,7 +19,7 @@ export async function verifyDefault(
       [abi],
       [address, 'isValidSignature', [arrayify(hash), sig]]
     );
-  } catch (e) {
+  } catch (e: any) {
     // @ts-ignore
     if (e.message.startsWith('missing revert data in call exception')) {
       return false;

diff --git a/src/sign/utils.ts b/src/sign/utils.ts
@@ -18,7 +18,7 @@ export async function verify(address, sig, data, network = '1', options = {}) {
     const recoverAddress = verifyTypedData(domain, types, message, sig);
     // console.log('Recover address', recoverAddress);
     if (address === recoverAddress) return true;
-  } catch (e) {
+  } catch (e: any) {
     // console.log('Could not recoverAddress:' + e.message);
   }
 

diff --git a/src/utils.ts b/src/utils.ts
@@ -67,7 +67,7 @@ async function parseScoreAPIResponse(res: any) {
   let data: any = await res.text();
   try {
     data = JSON.parse(data);
-  } catch (e) {
+  } catch (e: any) {
     return Promise.reject({
       code: res.status || 500,
       message: 'Failed to parse response from score API',
@@ -206,7 +206,7 @@ export async function call(provider, abi: any[], call: any[], options?) {
   try {
     const params = call[2] || [];
     return await contract[call[1]](...params, options || {});
-  } catch (e) {
+  } catch (e: any) {
     return Promise.reject(e);
   }
 }
@@ -247,7 +247,7 @@ export async function multicall(
     return results.map((call, i) =>
       itf.decodeFunctionResult(calls[i][1], call)
     );
-  } catch (e) {
+  } catch (e: any) {
     return Promise.reject(e);
   }
 }
@@ -265,7 +265,7 @@ export async function subgraphRequest(url: string, query, options: any = {}) {
   let responseData: any = await res.text();
   try {
     responseData = JSON.parse(responseData);
-  } catch (e) {
+  } catch (e: any) {
     throw new Error(
       `Errors found in subgraphRequest: URL: ${url}, Status: ${
         res.status
@@ -390,7 +390,7 @@ export async function getScores(
     return options.returnValue === 'all'
       ? response.result
       : response.result[options.returnValue || 'scores'];
-  } catch (e) {
+  } catch (e: any) {
     if (e.errno) {
       return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
     }
@@ -450,7 +450,7 @@ export async function getVp(
     const res = await fetch(url, init);
     const response = await parseScoreAPIResponse(res);
     return response.result;
-  } catch (e) {
+  } catch (e: any) {
     if (e.errno) {
       return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
     }
@@ -504,7 +504,7 @@ export async function validate(
     const res = await fetch(url, init);
     const response = await parseScoreAPIResponse(res);
     return response.result;
-  } catch (e) {
+  } catch (e: any) {
     if (e.errno) {
       return Promise.reject({ code: e.errno, message: e.toString(), data: '' });
     }
@@ -574,7 +574,7 @@ export async function getSpaceUri(
 ): Promise<string | null> {
   try {
     return await getEnsTextRecord(id, 'snapshot', network, options);
-  } catch (e) {
+  } catch (e: any) {
     console.log(e);
     return null;
   }

diff --git a/src/utils/web3.ts b/src/utils/web3.ts
@@ -9,7 +9,7 @@ export async function getBlockNumber(provider) {
   try {
     const blockNumber: any = await provider.getBlockNumber();
     return parseInt(blockNumber);
-  } catch (e) {
+  } catch (e: any) {
     return Promise.reject();
   }
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -6,12 +6,13 @@
     "module": "es6",
     "noImplicitAny": false,
     "outDir": "./dist",
-    "target": "es5",
+    "target": "es6",
     "lib": ["es2018", "dom", "esnext"],
     "resolveJsonModule": true,
     "allowSyntheticDefaultImports": true,
     "moduleResolution": "node",
-    "downlevelIteration": true
+    "downlevelIteration": true,
+    "skipLibCheck": true
   },
   "include": [
     "src/**/*"

diff --git a/yarn.lock b/yarn.lock
@@ -4934,10 +4934,10 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.8.3:
-  version "3.8.3"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"
-  integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==
+typescript@^5.0.0:
+  version "5.5.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.3.tgz#e1b0a3c394190838a0b168e771b0ad56a0af0faa"
+  integrity sha512-/hreyEujaB0w76zKo6717l3L0o/qEUtRgdvUBvlkhoWeOVMjMuHNHk0BRBzikzuGDqNmPQbg5ifMEqsHLiIUcQ==
 
 ufo@^1.1.2:
   version "1.1.2"