Merge pull request #99 from rsharifnasab/main

Remove sensetive data from tracing
snapp-incubator · Oct 14, 2024 · 2043c8b · 2043c8b
2 parents 5db2880 + 95cdbe9
commit 2043c8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 18 deletions.
diff --git a/internal/api/acl.go b/internal/api/acl.go
@@ -55,9 +55,6 @@ func (a API) ACLv1(c *fiber.Ctx) error {
 	span.SetAttributes(
 		attribute.String("access", request.Access.String()),
 		attribute.String("topic", request.Topic),
-		attribute.String("token", request.Token),
-		attribute.String("username", request.Username),
-		attribute.String("password", request.Password),
 		attribute.String("authenticator", auth.GetCompany()),
 	)
 
@@ -152,9 +149,6 @@ func (a API) ACLv2(c *fiber.Ctx) error {
 	span.SetAttributes(
 		attribute.String("access", request.Action),
 		attribute.String("topic", request.Topic),
-		attribute.String("token", request.Token),
-		attribute.String("username", request.Username),
-		attribute.String("password", request.Password),
 		attribute.String("authenticator", auth.GetCompany()),
 	)
 

diff --git a/internal/api/auth.go b/internal/api/auth.go
@@ -47,12 +47,7 @@ func (a API) Authv1(c *fiber.Ctx) error {
 
 	auth := a.Authenticator(vendor)
 
-	span.SetAttributes(
-		attribute.String("token", request.Token),
-		attribute.String("username", request.Username),
-		attribute.String("password", request.Password),
-		attribute.String("authenticator", auth.GetCompany()),
-	)
+	span.SetAttributes(attribute.String("authenticator", auth.GetCompany()))
 
 	err := auth.Auth(token)
 	if err != nil {
@@ -114,12 +109,7 @@ func (a API) Authv2(c *fiber.Ctx) error {
 
 	auth := a.Authenticator(vendor)
 
-	span.SetAttributes(
-		attribute.String("token", request.Token),
-		attribute.String("username", request.Username),
-		attribute.String("password", request.Password),
-		attribute.String("authenticator", auth.GetCompany()),
-	)
+	span.SetAttributes(attribute.String("authenticator", auth.GetCompany()))
 
 	err := auth.Auth(token)
 	if err != nil {