Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: datavzrd wrapper v3.12.1, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb, pure download rules as localrules #92

Merged
merged 38 commits into from
Jun 13, 2024

Conversation

dlaehnemann
Copy link
Collaborator

this then uses datavzrd=2.36.10

@dlaehnemann dlaehnemann changed the title perf: update datavzrd to wrapper v3.10.2 datavzrd.smk perf: datavzrd wrapper v3.11.0, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb Jun 5, 2024
@dlaehnemann
Copy link
Collaborator Author

For now, I'll turn off the reactivated testing of isoformSwitchAnalyzer, to get the tests to pass here and merge this PR.

And then, I'll fix isoformSwitchAnalyzer on a new branch, where we'll also fix the Ensembl cDNA fasta file, as the current failure is due to the Ensembl GTF and the Ensembl cDNA FASTA file being out of sync, see here:
https://www.r-bloggers.com/2020/01/comparing-ensembl-gtf-and-cdna/

Removing Ensembl cDNA FASTA redundancies (the same HGNC gene symbol appearing with multiple Ensembl gene_ids due to scaffolds and other issues), will probably remove most of the FASTA-only transcript IDs as well, so should be part of the isoformSwitchAnalyzer fix...

@dlaehnemann dlaehnemann changed the title perf: datavzrd wrapper v3.11.0, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb perf: datavzrd wrapper v3.11.0, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb, pure download rules as localrules Jun 12, 2024
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic, thanks a lot! Just some minor things below.

workflow/resources/datavzrd/diffexp-template.yaml Outdated Show resolved Hide resolved
workflow/rules/common.smk Show resolved Hide resolved
workflow/rules/datavzrd.smk Outdated Show resolved Hide resolved
workflow/rules/datavzrd.smk Outdated Show resolved Hide resolved
workflow/rules/datavzrd.smk Outdated Show resolved Hide resolved
workflow/rules/common.smk Show resolved Hide resolved
@fxwiegand
Copy link
Contributor

It would probably also makes sense to upgrade to 2.36.15 as this will probably save loads of space in the resulting reports 😊

@dlaehnemann dlaehnemann changed the title perf: datavzrd wrapper v3.11.0, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb, pure download rules as localrules perf: datavzrd wrapper v3.12.1, offer-excel configurable, free disk space for CI, dynamic sleuth_init mem_mb, pure download rules as localrules Jun 13, 2024
Co-authored-by: Johannes Köster <[email protected]>
@dlaehnemann dlaehnemann merged commit 70850fb into main Jun 13, 2024
6 checks passed
@dlaehnemann dlaehnemann deleted the perf/update-datavzrd-wrapper-to-3-10-2 branch June 13, 2024 13:37
johanneskoester pushed a commit that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.7.0](v2.6.0...v2.7.0)
(2024-08-15)


### Features

* Improve datavzrd tables
([#93](#93))
([93512b8](93512b8))


### Bug Fixes

* Fix missing output in spia.R when no significant genes are found
([#103](#103))
([bc0d017](bc0d017))
* Handle missing bam columns in units.tsv
([#105](#105))
([bae88d0](bae88d0))
* Remove non-existent outputs in spia rule
([#102](#102))
([0fbb930](0fbb930))
* update to latest datavzrd
([417ec3b](417ec3b))


### Performance Improvements

* datavzrd wrapper `v3.12.1`, offer-excel configurable, free disk space
for CI, dynamic sleuth_init mem_mb, pure download rules as localrules
([#92](#92))
([70850fb](70850fb))
* Update datavzrd wrapper
([#98](#98))
([e5eb0e0](e5eb0e0))
* Update samtools fast separate wrapper
([#100](#100))
([65d8f41](65d8f41))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants