Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update max in memory rows for diffexp report #122

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

fxwiegand
Copy link
Contributor

@fxwiegand fxwiegand commented Oct 15, 2024

This PR increases the maximum in memory genes/transcripts for the diffexp datavzrd report.

Summary by CodeRabbit

  • New Features

    • Increased capacity for handling larger datasets in memory by adjusting the max-in-memory-rows parameter from 15,000 to 42,000.
  • Bug Fixes

    • No bug fixes were included in this release.
  • Documentation

    • Configuration file structure remains unchanged, ensuring clarity in dataset definitions and views.

Copy link

coderabbitai bot commented Oct 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the diffexp-template.yaml configuration file used for differential expression analysis. The primary change is the increase of the max-in-memory-rows parameter from 15,000 to 42,000, allowing for larger datasets to be handled in memory. The overall structure of the YAML file remains unchanged, with various datasets and views still defined under their respective keys.

Changes

File Path Change Summary
workflow/resources/datavzrd/diffexp-template.yaml Updated max-in-memory-rows from 15,000 to 42,000.

Possibly related PRs

  • fix: Convert pval and qval to heatmap #123: This PR modifies the same diffexp-template.yaml file, specifically changing the plotting specifications for pval and qval, which are relevant to differential expression analysis, similar to the changes made in the main PR regarding the configuration for differential expression analysis.

Suggested reviewers

  • johanneskoester

Poem

🐇 In the meadow where data does grow,
A tweak was made, now it flows!
From fifteen to forty-two, rows in the light,
Handling more data feels just right!
With views and datasets all in their place,
Analysis blooms, a joyful embrace! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question / suggestion for the number used here...

workflow/resources/datavzrd/diffexp-template.yaml Outdated Show resolved Hide resolved
@dlaehnemann dlaehnemann merged commit 830e678 into main Oct 18, 2024
3 of 4 checks passed
@dlaehnemann dlaehnemann deleted the fxwiegand-patch-1 branch October 18, 2024 08:59
dlaehnemann pushed a commit that referenced this pull request Oct 18, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.8.2](v2.8.1...v2.8.2)
(2024-10-18)


### Bug Fixes

* Convert pval and qval to heatmap
([#123](#123))
([478c759](478c759))
* Move NA values to end of table
([#124](#124))
([df807a5](df807a5))
* Update max in memory rows for diffexp report
([#122](#122))
([830e678](830e678))


### Performance Improvements

* Update to latest datavzrd wrapper
([#125](#125))
([3a4c020](3a4c020))
* Update to latest datavzrd wrapper version
([#120](#120))
([7b2767c](7b2767c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants